Add support data for fabric monitoring in CONFIG_DB. by jfeng-arista · Pull Request #14170 · sonic-net/sonic-buildimage

jfeng-arista · 2023-03-08T18:24:20Z

Added support data for fabric monitoring in CONFIG_DB

The CONFIG_DB now has the FABRIC_MONITOR|FABRIC_MONITOR_DATA table for default value for fabric port monitoring. An example output of getting this table is:

sonic-db-cli CONFIG_DB hgetall "FABRIC_MONITOR|FABRIC_MONITOR_DATA"
{'monErrThreshCrcCells': '1', 'monErrThreshRxCells': '61035156', 'monPollThreshIsolation': '1', 'monPollThreshRecovery': '8'}

The CONFIG_DB now also has a table for each fabric port for its isolate status.
An example output of getting this table is:

sonic-db-cli CONFIG_DB hgetall "FABRIC_PORT|Fabric20"
{'alias': 'Fabric20', 'isolateStatus': 'False', 'lanes': '20'}

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

kenneth-arista · 2023-03-14T02:12:28Z

@rlhui @arlakshm for viz

rlhui · 2023-03-15T17:12:00Z

@sanmalho-git - please add reviewers as you see fit, thanks.

arlakshm

add comments, Please add some unit tests for this.

device/arista/x86_64-arista_7800r3_48cq2_lc/fabric_port_config.ini

device/arista/x86_64-arista_7800r3_48cqm2_lc/fabric_port_config.ini

arlakshm · 2023-04-17T19:24:36Z

src/sonic-config-engine/minigraph.py

    results['CONSOLE_PORT'] = console_ports

+    # Get the global fabric monitoring data
+    curDir = os.getcwd()


is this needed, curDir is not used?

arlakshm · 2023-04-17T19:25:19Z

src/sonic-config-engine/portconfig.py

+            # alias to asic_port_name mapping
+            if 'asic_port_name' in data:
+                port_alias_asic_map[data['alias']] = data['asic_port_name'].strip()
+    return (ports, port_alias_map, port_alias_asic_map)


port_alias_map, port_alias_asic_map is not used, is this needed?

src/sonic-config-engine/portconfig.py

jfeng-arista · 2023-05-02T00:08:30Z

/Azpw run Azure.sonic-buildimage

mssonicbld · 2023-05-02T00:08:32Z

/AzurePipelines run Azure.sonic-buildimage

azure-pipelines · 2023-05-02T00:08:43Z

Azure Pipelines successfully started running 1 pipeline(s).

#### Why I did it Table FABRIC_MONITOR|FABRIC_MONITOR_DATA in CONFIG_DB was added in #14170 The YANG model for that table is still missing. Need to wait #14170 get merged first. #### How I did it Added new YANG model FABRIC_MONITOR and associated unit tests. #### How to verify it Passing unit tests

kenneth-arista · 2023-06-15T06:19:42Z

@arlakshm looks like @jfeng-arista addressed all comments. Can we get this merged before the 202305 cut-off?

arlakshm

LGTM

@jfeng-arista

#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in #14170. #### How I did it This is a clone of @jfeng-arista's PR #14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.

StormLiangMS · 2023-07-17T15:37:06Z

@gechiang if this is a bug fix and we needed in 202305, pls have ADO to track, each commit to 202305 need ADO.

gechiang · 2023-07-19T21:35:43Z

@StormLiangMS
MSFT ADO: 24595606

Thanks!

Added support data for fabric monitoring in CONFIG_DB The CONFIG_DB now has the FABRIC_MONITOR|FABRIC_MONITOR_DATA table for default value for fabric port monitoring. An example output of getting this table is: sonic-db-cli CONFIG_DB hgetall "FABRIC_MONITOR|FABRIC_MONITOR_DATA" {'monErrThreshCrcCells': '1', 'monErrThreshRxCells': '61035156', 'monPollThreshIsolation': '1', 'monPollThreshRecovery': '8'} The CONFIG_DB now also has a table for each fabric port for its isolate status. An example output of getting this table is: sonic-db-cli CONFIG_DB hgetall "FABRIC_PORT|Fabric20" {'alias': 'Fabric20', 'isolateStatus': 'False', 'lanes': '20'}

mssonicbld · 2023-08-06T14:19:44Z

Cherry-pick PR to 202305: #16045

Added support data for fabric monitoring in CONFIG_DB The CONFIG_DB now has the FABRIC_MONITOR|FABRIC_MONITOR_DATA table for default value for fabric port monitoring. An example output of getting this table is: sonic-db-cli CONFIG_DB hgetall "FABRIC_MONITOR|FABRIC_MONITOR_DATA" {'monErrThreshCrcCells': '1', 'monErrThreshRxCells': '61035156', 'monPollThreshIsolation': '1', 'monPollThreshRecovery': '8'} The CONFIG_DB now also has a table for each fabric port for its isolate status. An example output of getting this table is: sonic-db-cli CONFIG_DB hgetall "FABRIC_PORT|Fabric20" {'alias': 'Fabric20', 'isolateStatus': 'False', 'lanes': '20'} Co-authored-by: jfeng-arista <[email protected]>

@jfeng-arista

#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in sonic-net#14170. #### How I did it This is a clone of @jfeng-arista's PR sonic-net#14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.

@jfeng-arista

#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in #14170. #### How I did it This is a clone of @jfeng-arista's PR #14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.

Added support data for fabric monitoring in CONFIG_DB The CONFIG_DB now has the FABRIC_MONITOR|FABRIC_MONITOR_DATA table for default value for fabric port monitoring. An example output of getting this table is: sonic-db-cli CONFIG_DB hgetall "FABRIC_MONITOR|FABRIC_MONITOR_DATA" {'monErrThreshCrcCells': '1', 'monErrThreshRxCells': '61035156', 'monPollThreshIsolation': '1', 'monPollThreshRecovery': '8'} The CONFIG_DB now also has a table for each fabric port for its isolate status. An example output of getting this table is: sonic-db-cli CONFIG_DB hgetall "FABRIC_PORT|Fabric20" {'alias': 'Fabric20', 'isolateStatus': 'False', 'lanes': '20'}

@jfeng-arista

#### Why I did it Introduce YANG model for FABRIC in CONFIG_DB, which was added in sonic-net#14170. #### How I did it This is a clone of @jfeng-arista's PR sonic-net#14282 to resolve conflicts with upstream changes. #### How to verify it Passing pipeline build is sufficient.

Added support data for fabric monitoring in CONFIG_DB The CONFIG_DB now has the FABRIC_MONITOR|FABRIC_MONITOR_DATA table for default value for fabric port monitoring. An example output of getting this table is: sonic-db-cli CONFIG_DB hgetall "FABRIC_MONITOR|FABRIC_MONITOR_DATA" {'monErrThreshCrcCells': '1', 'monErrThreshRxCells': '61035156', 'monPollThreshIsolation': '1', 'monPollThreshRecovery': '8'} The CONFIG_DB now also has a table for each fabric port for its isolate status. An example output of getting this table is: sonic-db-cli CONFIG_DB hgetall "FABRIC_PORT|Fabric20" {'alias': 'Fabric20', 'isolateStatus': 'False', 'lanes': '20'}

Add support data for fabric monitoring in CONFIG_DB. (sonic-net#14170)

Add support data for fabric monitoring in CONFIG_DB.

c03ffa3

rlhui assigned jfeng-arista Mar 15, 2023

rlhui requested review from arlakshm, rlhui and tjchadaga March 15, 2023 17:10

This was referenced Mar 16, 2023

Add YANG model for FABRIC_PORT #14282

Closed

YANG model for FABRIC_MONITOR|FABRIC_MONITOR_DATA #14390

Merged

jfeng-arista mentioned this pull request Apr 1, 2023

Update fabric link monitoring plan. sonic-net/SONiC#1013

Merged

arlakshm reviewed Apr 17, 2023

View reviewed changes

Remove not used code based on review comments.

97f39de

arlakshm added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label May 15, 2023

Remove unused variable.

9754d7d

arlakshm reviewed Jun 15, 2023

View reviewed changes

arlakshm approved these changes Jun 16, 2023

View reviewed changes

arlakshm added Request for 202211 Branch Request for 202305 Branch labels Jun 16, 2023

yxieca merged commit 4b31e30 into sonic-net:master Jun 16, 2023

kenneth-arista mentioned this pull request Jun 26, 2023

Add YANG model for FABRIC_PORT #15629

Merged

9 tasks

gechiang mentioned this pull request Jul 13, 2023

Add support data for fabric monitoring in CONFIG_DB. (#14170) Azure/sonic-buildimage-msft#61

Merged

5 tasks

gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Jul 13, 2023

StormLiangMS added the Approved for 202305 Branch label Aug 6, 2023

mssonicbld added the Created PR to 202305 Branch label Aug 6, 2023

mssonicbld mentioned this pull request Aug 6, 2023

[action] [PR:14170] Add support data for fabric monitoring in CONFIG_DB. #16045

Merged

8 tasks

mssonicbld added Included in 202305 Branch and removed Created PR to 202305 Branch labels Aug 7, 2023

gechiang removed the Request for 202211 Branch label Sep 1, 2023

mssonicbld mentioned this pull request Sep 3, 2023

[action] [PR:15629] Add YANG model for FABRIC_PORT #16398

Merged

9 tasks

mlok-nokia pushed a commit to mlok-nokia/sonic-buildimage that referenced this pull request Jun 5, 2024

Merge pull request sonic-net#61 from gechiang/ghc-202205

afa2423

Add support data for fabric monitoring in CONFIG_DB. (sonic-net#14170)

Conversation

jfeng-arista commented Mar 8, 2023

Why I did it

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

kenneth-arista commented Mar 14, 2023

Uh oh!

rlhui commented Mar 15, 2023

Uh oh!

arlakshm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

arlakshm Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

arlakshm Apr 17, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jfeng-arista commented May 2, 2023

Uh oh!

mssonicbld commented May 2, 2023

Uh oh!

azure-pipelines bot commented May 2, 2023

Uh oh!

kenneth-arista commented Jun 15, 2023

Uh oh!

arlakshm left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

StormLiangMS commented Jul 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gechiang commented Jul 19, 2023

Uh oh!

mssonicbld commented Aug 6, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

arlakshm left a comment •

edited

Loading

StormLiangMS commented Jul 17, 2023 •

edited

Loading